react-icons icon indicating copy to clipboard operation
react-icons copied to clipboard

release `@react-icons/all-files`

Open maddhruv opened this issue 3 years ago • 11 comments

Describe the bug Looks like @react-icons/all-files hasn't been released lately with react-icons so I am missing the newly added icons packs

Minimal sample repository Not Required

Expected behavior For example Tabler Icons are missing from all-files, Can you please do a release with latest react-icons

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Device: [e.g. PC, iPhone6]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

maddhruv avatar Sep 01 '22 01:09 maddhruv

@kamijin-fanta

maddhruv avatar Sep 01 '22 01:09 maddhruv

@maddhruv I believe it is caused by too many files generated, causing npm to refuse to host the package.

Here is what happened when I was trying to publish the package under my own npm scope:

image

SukkaW avatar Sep 01 '22 04:09 SukkaW

I think by npm pack and npm publish --tarball` using the tarball you would be able to publish, can you please try

maddhruv avatar Sep 01 '22 04:09 maddhruv

Hey @nolanleung looks like with the latest release as well, the all-files package is not updated. Can you look into this?

maddhruv avatar Sep 05 '22 02:09 maddhruv

I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package.

kamijin-fanta avatar Oct 14 '22 14:10 kamijin-fanta

I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package.

One possible solution is to split the ESM and CJS packages, which could reduce the number of files to half.

SukkaW avatar Oct 14 '22 14:10 SukkaW

I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase.

kamijin-fanta avatar Oct 14 '22 14:10 kamijin-fanta

I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase.

While it may defeat the purpose of having a package named "all-files", maybe the icons could be split up into packages based on their icon library? So, a @react-icons/fa package, a @react-icons/hi package, and so-on?

codsane avatar Dec 30 '22 02:12 codsane

Those packages already exist but they don't contain the separate icons. The main setup should just be fixed to export single files in each package and then you should deprecate this duplicate "all-icons" package.

fregante avatar Dec 30 '22 02:12 fregante

To all the people still finding a workaround, we can also do: npm install link_to_gzipped_tarball.

For an Example:

$ npm i https://github.com/react-icons/react-icons/releases/download/v4.7.1/react-icons-all-files-4.7.1.tgz

This also adds a dependency in the package.json file.

References:

  • https://docs.npmjs.com/cli/v8/commands/npm-install
  • https://github.com/react-icons/react-icons/releases (<- goto this page for latest releases)

Wolverin-e avatar Feb 27 '23 10:02 Wolverin-e

When is this being updated?

stephenasuncionDEV avatar Dec 12 '23 23:12 stephenasuncionDEV