web icon indicating copy to clipboard operation
web copied to clipboard

Published 20 hours ago • verified publisher icon react-hookz

Create an example for `useDeepCompareEffect`

Open JoeDuncko opened this issue 2 years ago • 3 comments

What docs page needs to be fixed?

  • Section:
  • Page:

What is the problem?

Currently useDeepCompareEffect does not have an example in the docs.

What should be changed to fix the problem?

We should make one.

JoeDuncko avatar Jan 14 '22 00:01 JoeDuncko

Also, for useCustomCompareEffect

xobotyi avatar Jan 17 '22 11:01 xobotyi

For useDeepCompareEffect, how about this?

For useCustomCompareEffects, how about comparing 2 objects by hashing them and comparing their hashes rather than a deep compare?

kylemh avatar Jan 17 '22 11:01 kylemh

Also, for useCustomCompareEffect

That's a separate issue, https://github.com/react-hookz/web/issues/352

@kylemh I really like the hash comparison for useCustomCompareEffect.

JoeDuncko avatar Jan 17 '22 23:01 JoeDuncko

:tada: This issue has been resolved in version 16.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

xobotyi avatar Oct 22 '22 20:10 xobotyi