resolvers icon indicating copy to clipboard operation
resolvers copied to clipboard

feat: effect-ts resolver

Open binaryartifex opened this issue 1 year ago • 5 comments

Initial submission of an effect-ts compatible react-hook-form resolver that accepts schemas from the @effect/schema library.

binaryartifex avatar May 06 '24 10:05 binaryartifex

@bluebill1049 cheers for the approvals mate. but im at a loss now as to how to fix this last failing check...generate a whole new pnpm-lock file maybe? im cautious of doing that as its bitten me in the ass in the past, especially with older or legacy transient packages in the mix...

binaryartifex avatar May 07 '24 10:05 binaryartifex

so it looks like the lockfile pnpm version got bumped from 6 to 9. the github workflows in the lib that leverage pnpm/action-setup@v2 are all set to use version 7. According to a few discussions, namely here and here, this might be the issue...

binaryartifex avatar May 07 '24 10:05 binaryartifex

@bluebill1049 cheers for the approvals mate. but im at a loss now as to how to fix this last failing check...generate a whole new pnpm-lock file maybe? im cautious of doing that as its bitten me in the ass in the past, especially with older or legacy transient packages in the mix...

@jorisre do you have any idea on this issue? 🙏

bluebill1049 avatar May 08 '24 00:05 bluebill1049

@bluebill1049 looks like that last commit bumping the pnpm versions in the github ci scripts fixed it :thumbsup:

binaryartifex avatar May 08 '24 00:05 binaryartifex

nice, let's go~

bluebill1049 avatar May 08 '24 01:05 bluebill1049

@bluebill1049 all good to go mate. are there scheduled releases or anything further needed from me with this pull request? when can we expect this to be merged?

binaryartifex avatar May 09 '24 00:05 binaryartifex

Let's release this Saturday, if something wrong I can still action it.

bluebill1049 avatar May 09 '24 00:05 bluebill1049

looks like need to upgrade node to 20: image

bluebill1049 avatar May 11 '24 02:05 bluebill1049

:tada: This PR is included in version 3.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar May 15 '24 00:05 github-actions[bot]