resolvers icon indicating copy to clipboard operation
resolvers copied to clipboard

[valibot 🤖]: Cannot conditionally require a field without freezing web page

Open demarchenac opened this issue 1 year ago • 2 comments

Describe the bug

As the title states, I'm just trying to conditionally require a field via the object() pipeline with valibot. I just so happens that the web page freezes when doing so.

To Reproduce

It's easy to reproduce since I have a working example on StackBlitz.

Basically, the way to trigger this bug is to modify the Required Input whenever any of the other three inputs doesn't have a value, if I were to fill those three up, modifying the Required Input doesn't freeze the web view.

Expected behavior

I should be able to conditionally require a field within a form depending on other fields.

Desktop (please complete the following information):

  • OS: Win 11
  • Browser Chrome
  • Version 116.0.5845.141 (64-bit)

Additional context

I've also added up to a related issue within the valibot repo

demarchenac avatar Sep 05 '23 16:09 demarchenac

Happens to me as well, makes object checks like sibling field equality impossible

irg1008 avatar Sep 11 '23 22:09 irg1008

Well, it ain't impossible, we need to create custom pipeline methods as shown in the following valibot issues:

But it's really weird that the custom pipeline method breakes the application when being used on object schemas

demarchenac avatar Sep 13 '23 07:09 demarchenac

@demarchenac, has your issue been resolved?

jorisre avatar Jul 03 '24 07:07 jorisre

@jorisre I managed to find a work-around avoiding the usage of custom, also this seems to be fixed on further releases

demarchenac avatar Jul 10 '24 13:07 demarchenac