react-draggable icon indicating copy to clipboard operation
react-draggable copied to clipboard

Fix git URL installation

Open szakharchenko opened this issue 3 years ago • 4 comments

These commits make it possible to install this package from a git URL.

szakharchenko avatar Mar 05 '21 13:03 szakharchenko

Thanks!

STRML avatar Mar 05 '21 14:03 STRML

Although, why avoid using make/yarn at prepare time? We want to ensure we're really using the correct build script, and this adds maintenance overhead if we change the build.

STRML avatar Mar 05 '21 14:03 STRML

The answer to your direct question is: to allow installation from Git URLs in environments where either yarn or make are not installed; likely that's not what you wanted to hear.

I would ask the opposite question, i.e. 'why use make&yarn at all instead of having the command line mentioned in the commit go to the "build" script, and have "prepare" just run "build"?'. It's a matter of taste, and up to you really, I don't intend to force you in any way; you can always merge only the first patch, or ignore the issue entirely.

szakharchenko avatar Mar 15 '21 13:03 szakharchenko

Would agree with you that Make is a superfluous dependency here and isn't really used for anything that scripts can't already handle.

STRML avatar Mar 15 '21 13:03 STRML