react-draggable icon indicating copy to clipboard operation
react-draggable copied to clipboard

Add ability to pass in scale prop to correctly move draggable element at different scales

Open commanderking opened this issue 7 years ago • 5 comments

Based on this original PR: https://github.com/mzabriskie/react-draggable/pull/217/files, but removed conflicts with dist files.

Also, added an additional test to check for scale prop and an example for the example page. Wasn't sure if we wanted the scale in DraggableCore, but can add it if desired.

@STRML, let me know if any changes are needed and I can get them in Thanks for maintaining this awesome library!

commanderking avatar Sep 13 '17 17:09 commanderking

This is really good idea! I'd like to use this feature as well.

ibio avatar Sep 14 '17 19:09 ibio

Hi @STRML, wondering whether there are any changes that need to be made to this PR for it to get merged in. Thanks again for all your work in maintaining this library!

commanderking avatar Oct 11 '17 17:10 commanderking

When to add scale attribute?

maixing avatar Dec 29 '17 01:12 maixing

Can we merge this PR ?

arnauddb avatar Apr 10 '18 21:04 arnauddb

I'm wondering if this can be done automatically by querying the element's own effective scale. This could be on an on/off switch but would prevent the need for manually tweaking scale.

STRML avatar Apr 10 '18 21:04 STRML