tree-select icon indicating copy to clipboard operation
tree-select copied to clipboard

fix: onOptionSelect should check selectedValue is or isn't be null

Open buxuku opened this issue 3 years ago • 2 comments

If I press Enter after the input does not match any entries, the component returns a null value and renders an empty component on the page. like:

image

so we should check the selectedValue is null

buxuku avatar Jan 18 '22 07:01 buxuku

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tree-select/J4rpXzTkFJbmtguGKzFdM3kYcMJW
✅ Preview: https://tree-select-git-fork-buxuku-fix-selected-4dc662-react-component.vercel.app

vercel[bot] avatar Jan 18 '22 07:01 vercel[bot]

Codecov Report

Merging #396 (56bf0d0) into master (8077330) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #396   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          462       462           
  Branches       123       128    +5     
=========================================
  Hits           462       462           
Impacted Files Coverage Δ
src/TreeSelect.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8077330...56bf0d0. Read the comment docs.

codecov[bot] avatar Jan 18 '22 07:01 codecov[bot]