time-picker icon indicating copy to clipboard operation
time-picker copied to clipboard

feat: Support milliseconds picker column (#149)

Open MrHeer opened this issue 5 years ago • 7 comments

close #149

MrHeer avatar May 14 '19 15:05 MrHeer

Codecov Report

Merging #151 into master will increase coverage by 0.77%. The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   91.86%   92.63%   +0.77%     
==========================================
  Files           6        6              
  Lines         381      421      +40     
  Branches       99      120      +21     
==========================================
+ Hits          350      390      +40     
  Misses         31       31
Impacted Files Coverage Δ
src/TimePicker.jsx 96.61% <100%> (+2.49%) :arrow_up:
src/Header.jsx 88.09% <75%> (-0.52%) :arrow_down:
src/Panel.jsx 92.42% <90%> (+0.89%) :arrow_up:
src/Combobox.jsx 93.33% <91.66%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88fa1ba...b871b80. Read the comment docs.

codecov[bot] avatar May 15 '19 11:05 codecov[bot]

@afc163 If you have time, please review. Thank you very much.

MrHeer avatar May 15 '19 13:05 MrHeer

@MrHeer Why was this closed? I'd like to see this feature merged.

abney317 avatar Jan 28 '20 17:01 abney317

@abney317 Because nobody handles it.

MrHeer avatar Jan 28 '20 23:01 MrHeer

@afc163 Any updates here?

abney317 avatar Jan 28 '20 23:01 abney317

You can

afc163 avatar Feb 02 '20 04:02 afc163

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/time-picker/l19wuwlna ✅ Preview: https://time-picker-git-fork-mrheer-feat-issues149.react-component.now.sh

vercel[bot] avatar Feb 07 '20 05:02 vercel[bot]