time-picker icon indicating copy to clipboard operation
time-picker copied to clipboard

Add mulit format support to TimePicker

Open NathanBP opened this issue 6 years ago • 5 comments

Allows format prop to allow an array of formats. The control then uses the array of formats when parsing a date from the input. The first value of the array determines the displayed format.

An example use case is that a user may want to enter a time as hmm but display as h:mm a.

NathanBP avatar Nov 16 '18 03:11 NathanBP

Test which is failing is already failing in master branch. Once this is fixed this pull request will pass the required checks.

NathanBP avatar Nov 16 '18 04:11 NathanBP

great

chenshuai2144 avatar Nov 19 '18 04:11 chenshuai2144

Codecov Report

Merging #133 into master will increase coverage by 0.49%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #133      +/-   ##
========================================
+ Coverage    89.5%    90%   +0.49%     
========================================
  Files           7      8       +1     
  Lines         381    390       +9     
  Branches       93     93              
========================================
+ Hits          341    351      +10     
+ Misses         40     39       -1
Impacted Files Coverage Δ
src/Panel.jsx 95.23% <ø> (ø) :arrow_up:
src/TimePicker.jsx 87.64% <100%> (ø) :arrow_up:
src/Combobox.jsx 93.9% <100%> (+0.15%) :arrow_up:
src/util/index.js 100% <100%> (ø)
src/Header.jsx 86.36% <100%> (+0.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8cb160...691270c. Read the comment docs.

codecov[bot] avatar Jan 03 '19 05:01 codecov[bot]

Could this implemented feature be taken into use? It would be helpful at least in some countries around the world.

tonihelminen avatar Oct 09 '19 08:10 tonihelminen