time-picker icon indicating copy to clipboard operation
time-picker copied to clipboard

Add a prop to configure whether `<kbd>esc</kbd>` should close the panel

Open cyrilfretlink opened this issue 6 years ago • 3 comments

This change is useful when you have multiple components listening to esc and you don’t want to close them all at the same time (e.g. if you render this component inside a modal or a side panel).

cyrilfretlink avatar Jun 11 '18 09:06 cyrilfretlink

Coverage Status

Coverage remained the same at 91.319% when pulling 273181d5cc2d23808d4302d763bbb7f7fa440c11 on fretlink:master into 77862aea6a529152c46fd43dee5fc48fce8100e8 on react-component:master.

coveralls avatar Jun 11 '18 09:06 coveralls

I think this would be useful, I am facing a problem is that when I click on the selector it closes both the selector modal and the other modal I have open.

Until this gets merged doo you know any workaround for this @cyrilfretlink ?

nasy avatar Jun 27 '18 17:06 nasy

It may be possible to toggle some state in onClose and to decide to close your other components or not based on this state but merging this fix would make it much easier.

cyrilfretlink avatar Jul 03 '18 08:07 cyrilfretlink