tabs icon indicating copy to clipboard operation
tabs copied to clipboard

feat: add new prop scrollPosition

Open OysterD3 opened this issue 1 year ago • 3 comments

https://github.com/ant-design/ant-design/issues/39433

Summary by CodeRabbit

  • 新功能

    • TabItem接口中增加了scrollPosition属性,提供更细致的标签滚动控制。
    • 新增文档文件scroll-position.md,展示滚动位置功能的示例。
    • 更新Tabs组件,支持根据用户选择动态调整标签的滚动位置。
    • TabNavList组件增强了滚动行为的灵活性,支持新的scrollPosition属性。
  • 文档

    • 更新README文档,包含新的scrollPosition属性信息。

OysterD3 avatar Nov 25 '24 09:11 OysterD3

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 9:33am

vercel[bot] avatar Nov 25 '24 09:11 vercel[bot]

Walkthrough

该拉取请求引入了一个新的属性 scrollPosition,该属性添加到 TabItem 接口中,并在 README.md 中进行了文档更新。新属性的类型为联合类型,包括 'start''end''center''auto',默认值为 'auto'。此外,新的 Markdown 文件 scroll-position.md 被添加到 docs/demo 目录中,包含了与滚动位置功能相关的示例代码。多个组件的接口也进行了相应的更新,以支持新的滚动位置配置。

Changes

文件路径 更改摘要
README.md 添加了 scrollPosition 属性到 TabItem 接口,并更新了文档以反映此更改。
docs/demo/scroll-position.md 创建了新的 Markdown 文件 scroll-position.md,包含演示的前言和代码块引用。
docs/examples/scroll-position.tsx 添加了新的 React 功能组件,使用 Tabs 组件并支持配置滚动位置,包含状态管理和用户交互示例。
src/TabNavList/index.tsx TabNavListProps 接口中添加了可选属性 scrollPosition,并更新 scrollToTab 函数以支持新属性。
src/Tabs.tsx TabsProps 接口中添加了 scrollPosition 属性,移除了 onNextClickonPrevClickkeyboard 属性。
src/interface.ts 更新了类型定义,添加了新类型 ScrollPosition,并进行了语法调整以符合 TypeScript 的类型声明规范。

Possibly related PRs

  • #747: 此 PR 修改了 TabNavList 组件,与主 PR 中添加的 scrollPosition 属性直接相关,均涉及标签导航行为的更改。

Poem

在兔子洞中跳跃欢,
新属性如春风般。
滚动位置更灵活,
标签跳跃乐无边。
文档更新不落后,
兔子欢唱庆新篇! 🐰✨

[!WARNING]

Rate limit exceeded

@OysterD3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 15ce46df94ea2d26ec92eee980705e2200acaa19 and 0078378a4cec148a4d2f6b4e9efa5edf5202f626.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 15ce46df94ea2d26ec92eee980705e2200acaa19 and 0078378a4cec148a4d2f6b4e9efa5edf5202f626.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Nov 25 '24 09:11 coderabbitai[bot]

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 95.44%. Comparing base (1b88fdd) to head (0078378). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/TabNavList/index.tsx 54.83% 14 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   97.72%   95.44%   -2.28%     
==========================================
  Files          18       18              
  Lines         702      724      +22     
  Branches      200      214      +14     
==========================================
+ Hits          686      691       +5     
- Misses         16       33      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 25 '24 09:11 codecov[bot]