tabs icon indicating copy to clipboard operation
tabs copied to clipboard

fix: fix tabs scroll slowly in some version

Open xiefenga opened this issue 1 year ago • 1 comments

add the conversion of line number to pixel value when the scroll value is line number in the wheel event related issue: Tabs scroll slowly in firefox some version such as 72.0 #657

xiefenga avatar Mar 10 '23 13:03 xiefenga

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 8:36am

vercel[bot] avatar Mar 10 '23 13:03 vercel[bot]

Conflicting

afc163 avatar Sep 29 '24 08:09 afc163

Walkthrough

此次更改涉及 src/hooks/useTouchMove.tssrc/util.ts 文件。useTouchMove.ts 文件中重新排列了导入语句,并修改了 onWheel 函数的实现方式,使用 getWheelDeltaOfPx 函数来获取 deltaXdeltaY 的值。util.ts 文件中新增了两个函数:isLineModegetWheelDeltaOfPx,用于处理 WheelEvent 的像素值计算和模式检查。

Changes

文件 更改摘要
src/hooks/useTouchMove.ts 导入语句重新排序,onWheel 函数实现修改,使用 getWheelDeltaOfPx 获取 deltaXdeltaY
src/util.ts 新增 isLineModegetWheelDeltaOfPx 函数,修改 React 导入语句。

Poem

🐇 在代码的世界里欢跃,
变更如春风轻拂面颊。
新函数如花绽放,
轮滚动,像舞蹈,
让我们一起欢庆这变化,
编程的乐趣无穷无尽,
兔子在此祝贺,快乐无边! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 29 '24 08:09 coderabbitai[bot]

这个问题在 Firefox 最新的版本中还存在么?如何重现?

afc163 avatar Sep 29 '24 08:09 afc163

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.47%. Comparing base (2fa1d36) to head (a4188a9). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/util.ts 81.81% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   97.72%   97.47%   -0.25%     
==========================================
  Files          18       18              
  Lines         702      713      +11     
  Branches      200      199       -1     
==========================================
+ Hits          686      695       +9     
- Misses         16       18       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 29 '24 08:09 codecov[bot]