table icon indicating copy to clipboard operation
table copied to clipboard

fix: Better type definition for dataIndex

Open tychenjiajun opened this issue 3 years ago • 11 comments

Fixes https://github.com/react-component/table/issues/435 https://github.com/react-component/table/issues/587 https://github.com/react-component/table/pull/532 https://github.com/react-component/table/pull/717

tychenjiajun avatar Feb 17 '22 02:02 tychenjiajun

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/ATW6XKoFv29uFA9TrJyzMhLFEcqT
✅ Preview: https://table-git-fork-tychenjiajun-master-react-component.vercel.app

vercel[bot] avatar Feb 17 '22 02:02 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.38%. Comparing base (9d4b3e4) to head (e9c5eec). Report is 245 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          34       35    +1     
  Lines         976      976           
  Branches      281      281           
=======================================
  Hits          970      970           
  Misses          6        6           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 17 '22 02:02 codecov[bot]

CI failed.

yoyo837 avatar Feb 17 '22 02:02 yoyo837

CI failed.

Fixing it

tychenjiajun avatar Feb 17 '22 02:02 tychenjiajun

定义出来一个类型吧

yoyo837 avatar Feb 17 '22 02:02 yoyo837

This pull request introduces 1 alert when merging e24588a1f8587c5789c6a90c8ae97748733f5b95 into 9d4b3e49abcce365c3777da88fafc3023f1a296e - view on LGTM.com

new alerts:

  • 1 for Syntax error

lgtm-com[bot] avatar Feb 17 '22 02:02 lgtm-com[bot]

定义出来一个类型吧

Done

tychenjiajun avatar Feb 17 '22 06:02 tychenjiajun

@yoyo837 就这样吧https://www.typescriptlang.org/play?#code/KYDwDg9gTgLgBDAnmYcAiBDGGCSA7AE1DgF44BnGKASzwHM4AfOPAVwFsAjYKJuKYBgIQ8AG0RwAFJRr0+bLjwCUAbQC6AbgCwAKFCRYCZKkzZ8REAEEoUDBLIChI8XBUzadNX0fCxElQrcUF7MPs4S0lQe8hxBqpq6uvrQ8Ego6MAAZhisojAASsAAxtAEACrGpHCFJVAEADzu9AA0cBh4iAB82jq6aagAoiBUGEUw5qD1NaUVKJ1VAN6uANbAErRwq4gQmdXFM8ZqAFwra60AdJemuISg1raIs8BT+3VPKltqnV4Avh9rOz2tXKhx6fUqAFU8AB3Wxgeple5wUAwYCEchwe52ertLrzMiImx8SSE3gotEEDFLURougwAAWJwAjHAfnAAPxwUlwE7c8nouDU2kMk4AJlZHP4gl8LhUpJUAAY1F5eUj+ZSpU4-K5LudaJkeHAIa19YaADIYSheTlQ2EYeEQ+YnPDAABuyjBenAKSM6WuEysNjsTxewKeVTQWRyeWmb2M+KBB3S6oxsYaTQYzECPFauPmzAzfCxiBxHXm7N0cCrp22uzTTy8KfQWBuFmLHMr1aGIzGoaTwH+tcTcZQalaheYxdLXT4acaUTkWdiObaZfmTZd7t4FZ01c1Mv8W0B9cOPM7VZPKEHx9eINHyOGFIxhc5YW117rt6erWzwW80vCGsbzDU8jnPfdAI-Yc72AEIjRhOF6m7WwxgDPsR2ATonWbMxbkDB4eVcBJei9AxUkqf08JDS9UDISNslyAov3jCMWwDYtqOYuYH1RAUhXoEU4AVCUdz3SiLEIyRxLuINHmMdCYM6RU4Ok-Dg3kmjOiUT1+jgIpWNwiwQyWDBmVaTgxVZTpwWTAzW1AEMVCZVpRS+GzUAIOyAxDVg8GWPAIGhPBrJ0XTdjotiqPkkyzLgCy4FFVoihOJZMjAMATgAcgAVlyzKJR+ELdIYCLDIc+T6OjJiQLmdy4HpLyopQBT51kOgf2XKAsLq6hGqMjTb1ajxxwXOhutCyoACtJr68rmpiihRo0OKTinX95kKoA

tychenjiajun avatar Feb 17 '22 06:02 tychenjiajun

这CI时灵时不灵…… 懂了……要手动触发……我还是本地试吧

tychenjiajun avatar Feb 20 '22 07:02 tychenjiajun

现在过不了应该是ts本身的bug吧

tychenjiajun avatar Feb 20 '22 14:02 tychenjiajun

https://github.com/microsoft/TypeScript/issues/40312

tychenjiajun avatar Feb 20 '22 14:02 tychenjiajun