table icon indicating copy to clipboard operation
table copied to clipboard

Published 20 hours ago • verified publisher icon react-component

fix: when using scrollTo the outer layer also scrolls at the same time

Open Fatpandac opened this issue 1 year ago • 6 comments

使用 scrollTo 替换 scrollIntoView，避免出现嵌套滚动 div 的时候，使内部 div 滚动同时导致外部的 div 也一起滚动。

https://github.com/ant-design/ant-design/issues/46467

Fatpandac avatar Dec 27 '23 09:12 Fatpandac

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 1:41pm

vercel[bot] avatar Dec 27 '23 09:12 vercel[bot]

ci failed

afc163 avatar Dec 27 '23 13:12 afc163

These two tests failed because I deprecated the scrollIntoView(). Can I remove these tests?

Fatpandac avatar Dec 27 '23 13:12 Fatpandac

Yes if these test cases is useless.

afc163 avatar Dec 27 '23 13:12 afc163

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b72776c) 99.51% compared to head (c93290a) 99.51%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1064   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          47       47           
  Lines        4518     4527    +9     
  Branches      571      572    +1     
=======================================
+ Hits         4496     4505    +9     
  Misses         22       22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 27 '23 13:12 codecov[bot]

看看 https://github.com/react-component/table/pull/1064/checks?check_run_id=19981960709

afc163 avatar Dec 27 '23 13:12 afc163