table icon indicating copy to clipboard operation
table copied to clipboard

fix: Resolved table's unexpected rounded corners

Open sunsunmonkey opened this issue 2 years ago • 11 comments

  • https://github.com/ant-design/ant-design/issues/46362 to resolve this issue

sunsunmonkey avatar Dec 10 '23 13:12 sunsunmonkey

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 3:25am

vercel[bot] avatar Dec 10 '23 13:12 vercel[bot]

照常加个用例,保险点。

yoyo837 avatar Dec 11 '23 02:12 yoyo837

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b0b072c) 99.51% compared to head (041669a) 99.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          47       47           
  Lines        4517     4521    +4     
  Branches      571      571           
=======================================
+ Hits         4495     4499    +4     
  Misses         22       22           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 11 '23 03:12 codecov[bot]

默认情况下不添加 class,应该 showHeader={false} 时添加 -without-header

MadCcc avatar Dec 11 '23 03:12 MadCcc

另外感觉只要把 border-radius 给 header 就好了,应该不需要额外添加 class?

MadCcc avatar Dec 11 '23 03:12 MadCcc

默认情况下不添加 class,应该 showHeader={false} 时添加 -without-header

他默认是有header吧,所以我的想法就是在showHeader={false}时去掉-header`,至于那个好像header本身就有一个boder-radius,我也不太清楚了,第一次尝试🤓,大佬见谅

sunsunmonkey avatar Dec 11 '23 03:12 sunsunmonkey

看下 snapshot,现在是多了一个 -header 的 class

MadCcc avatar Dec 11 '23 06:12 MadCcc

看下 snapshot,现在是多了一个 -header 的 class

是的,因为默认是有那个header然后,他有个圆角的属性在-container里,所以我想分离开来做,就是showheader为false时去掉-header,其他情况保留-header

sunsunmonkey avatar Dec 11 '23 06:12 sunsunmonkey

我推荐是直接把圆角样式写在 header 上,table 不带圆角,这样去掉 header 的时候就没有圆角了

MadCcc avatar Dec 11 '23 07:12 MadCcc

我推荐是直接把圆角样式写在 header 上,table 不带圆角,这样去掉 header 的时候就没有圆角了

ok,我再看看

sunsunmonkey avatar Dec 11 '23 07:12 sunsunmonkey

我尝试的其他解决方案 #46389

sunsunmonkey avatar Dec 11 '23 14:12 sunsunmonkey