slider icon indicating copy to clipboard operation
slider copied to clipboard

perf: add marks dot classname

Open howiepu opened this issue 3 years ago • 4 comments

I need to do something special with the dot for marks, but I don't have a class name for marks, so I think it's worth adding that.

howiepu avatar Aug 31 '22 05:08 howiepu

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ❌ Failed (Inspect) Apr 20, 2023 8:44am

vercel[bot] avatar Aug 31 '22 05:08 vercel[bot]

Codecov Report

Merging #842 (fb86e14) into master (5924005) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head fb86e14 differs from pull request most recent head 7a3fe19. Consider uploading reports for the commit 7a3fe19 to get more accurate results

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          13       13           
  Lines         535      540    +5     
  Branches      147      150    +3     
=======================================
+ Hits          534      539    +5     
  Misses          1        1           
Impacted Files Coverage Δ
src/context.ts 100.00% <ø> (ø)
src/Handles/Handle.tsx 100.00% <100.00%> (ø)
src/Slider.tsx 100.00% <100.00%> (ø)
src/Steps/Dot.tsx 100.00% <100.00%> (ø)
src/Steps/index.tsx 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 31 '22 05:08 codecov[bot]

Docs and test case please.

yoyo837 avatar Apr 15 '23 15:04 yoyo837

Prefer to have classNames: { markedDot: string } for Slider, not to add className by default. Then you can use like this:

<Slider classNames={{ markedDot: 'custom-dot' }} />

MadCcc avatar Apr 20 '23 09:04 MadCcc