select
select copied to clipboard
fix: onClear triggers onDeselect in multiple mode
fix #33790
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/react-component/select/FunJdqUfP2vUJXFGeJ2FZB48PGKM
✅ Preview: https://select-git-fork-imoctopus-fix-onclear-react-component.vercel.app
Codecov Report
Merging #731 (bd83a02) into master (08757c1) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 25 25
Lines 1038 1039 +1
Branches 346 346
=======================================
+ Hits 1033 1034 +1
Misses 4 4
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/BaseSelect.tsx | 100.00% <ø> (ø) |
|
src/Select.tsx | 100.00% <100.00%> (ø) |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
请问改进展如何
no effect. it calls onDeselect again. if u have lots of tags selected, it will be called many times.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
select | ✅ Ready (Inspect) | Visit Preview | Jun 28, 2022 at 0:45AM (UTC) |
Hello,
Do you known if this PR can be merged soon?
Please rebase and add a test case for this.
done
When will this optimization be merged?
@yoyo837 Hi, it would be very cool if you could quickly take a look on this, since it's preventing a lot of people from updating ant design downstream.