select icon indicating copy to clipboard operation
select copied to clipboard

fix: onClear triggers onDeselect in multiple mode

Open madocto opened this issue 2 years ago • 9 comments

fix #33790

madocto avatar Mar 21 '22 16:03 madocto

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/FunJdqUfP2vUJXFGeJ2FZB48PGKM
✅ Preview: https://select-git-fork-imoctopus-fix-onclear-react-component.vercel.app

vercel[bot] avatar Mar 21 '22 16:03 vercel[bot]

Codecov Report

Merging #731 (bd83a02) into master (08757c1) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          25       25           
  Lines        1038     1039    +1     
  Branches      346      346           
=======================================
+ Hits         1033     1034    +1     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/BaseSelect.tsx 100.00% <ø> (ø)
src/Select.tsx 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Mar 25 '22 16:03 codecov[bot]

请问改进展如何

SCWR avatar Apr 27 '22 08:04 SCWR

no effect. it calls onDeselect again. if u have lots of tags selected, it will be called many times.

tiber2013 avatar May 21 '22 06:05 tiber2013

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 0:45AM (UTC)

vercel[bot] avatar May 26 '22 03:05 vercel[bot]

Hello,

Do you known if this PR can be merged soon?

xrutayisire avatar Jun 25 '22 15:06 xrutayisire

Please rebase and add a test case for this.

yoyo837 avatar Jun 25 '22 15:06 yoyo837

done

madocto avatar Jun 28 '22 12:06 madocto

When will this optimization be merged?

leotian avatar Aug 15 '22 06:08 leotian

@yoyo837 Hi, it would be very cool if you could quickly take a look on this, since it's preventing a lot of people from updating ant design downstream.

ncioj10 avatar Sep 22 '22 15:09 ncioj10