select icon indicating copy to clipboard operation
select copied to clipboard

chore: better select types

Open claudiocro opened this issue 4 years ago • 4 comments

This is introducing a breaking typescript change for this two options:

  • [ ] optionFilterProp
  • [ ] optionLabelProp

they are now checking against OptionType to make sure the property is a valid one.

claudiocro avatar Jan 26 '22 10:01 claudiocro

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/5hTfSjycYL6YrdYVXEMCQ383q6Gm
✅ Preview: https://select-git-fork-claudiocro-f-select-opti-d023c7-react-component.vercel.app

vercel[bot] avatar Jan 26 '22 10:01 vercel[bot]

Codecov Report

Merging #714 (7a3289f) into master (f7ed85e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          25       25           
  Lines        1009     1009           
  Branches      334      334           
=======================================
  Hits         1004     1004           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/Select.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7ed85e...7a3289f. Read the comment docs.

codecov[bot] avatar Jan 26 '22 11:01 codecov[bot]