select icon indicating copy to clipboard operation
select copied to clipboard

The tests in this repo silently fail type checking

Open dgreene1 opened this issue 5 years ago • 0 comments

Context: While fixing https://github.com/react-component/select/issues/595 I noticed that the tests are not passing the TypeScript compiler, but nothing is catching that in the CICD pipeline. This is dangerous since the types are what help us to understand the use cases our users have. By making this change, we can prevent significant future bugs.

Proposal: I will ensure that if there are any Typescript errors in the ./test directory, a PR can not merge. I will do this by updating the "test" script in package.json to look like:

    "test": "npm run type-check:tests && father test",
    "type-check:tests": "tsc -p ./tests/tsconfig.json --noEmit",

Is that acceptable?

dgreene1 avatar Feb 12 '21 15:02 dgreene1