select icon indicating copy to clipboard operation
select copied to clipboard

adds type safety for value, key, and option props for Select and Option

Open dgreene1 opened this issue 4 years ago • 6 comments

fixes https://github.com/react-component/select/issues/595 in a backwards-compatible manner.

dgreene1 avatar Feb 12 '21 04:02 dgreene1

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/fwwwo7ipd
✅ Preview: https://select-git-fork-dgreene1-issue-595-typesforoptions.react-component.vercel.app

vercel[bot] avatar Feb 12 '21 04:02 vercel[bot]

Codecov Report

Merging #596 (f5ac967) into master (65c2e47) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          20       20           
  Lines         968      968           
  Branches      323      323           
=======================================
  Hits          960      960           
  Misses          7        7           
  Partials        1        1           
Impacted Files Coverage Δ
src/Select.tsx 100.00% <ø> (ø)
src/generate.tsx 99.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65c2e47...51030c3. Read the comment docs.

codecov[bot] avatar Feb 12 '21 04:02 codecov[bot]

This pull request introduces 1 alert when merging c2683104db16924a5d0391a0d8d21a730db7026b into 65c2e47f26f9a895adb26e6506e276b825d5193c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Feb 12 '21 05:02 lgtm-com[bot]

:(

mellis481 avatar Oct 18 '21 17:10 mellis481

图片

afc163 avatar Oct 19 '21 03:10 afc163

It wasn’t in conflict when I submitted it. At this point I don’t care about this feature anymore. So either someone can take it over or we can close it.

dgreene1 avatar Oct 19 '21 11:10 dgreene1