select icon indicating copy to clipboard operation
select copied to clipboard

fix: circular reference in the option prop of select

Open Chersquwn opened this issue 5 years ago • 2 comments

If return newOption, props in newOption will cause circular reference. props of newOption will has props of newOption.

option.props.props.props === option.props   // this is true

Chersquwn avatar Sep 21 '20 11:09 Chersquwn

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/mzvaredn1
✅ Preview: https://select-git-fork-chersquwn-fix-select-option-props.react-component.vercel.app

vercel[bot] avatar Sep 21 '20 11:09 vercel[bot]

Codecov Report

Merging #552 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          20       20           
  Lines         957      957           
  Branches      324      324           
=======================================
  Hits          951      951           
  Misses          5        5           
  Partials        1        1           
Impacted Files Coverage Δ
src/utils/valueUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f05d794...98ddb9a. Read the comment docs.

codecov[bot] avatar Sep 21 '20 11:09 codecov[bot]