picker icon indicating copy to clipboard operation
picker copied to clipboard
verified publisher icon react-component

fix: presets和maxDate的对比

Open Roxannej opened this issue 7 months ago • 3 comments

maxDate和presets的值的对比，禁用点击 https://github.com/ant-design/ant-design/issues/53693

Summary by CodeRabbit

  • 新功能

    • 预设面板及相关组件新增可选的最大日期（maxDate）限制，超出最大日期的预设项将自动禁用，无法点击或悬停选择。

  • 测试

    • 增加了针对禁用预设项的测试用例，确保超出最大日期的预设不会触发事件回调。
    • 新增多种预设类型与最大日期边界条件的测试，提升预设交互的覆盖率和稳定性。

Roxannej avatar May 26 '25 09:05 Roxannej

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 0:05am

vercel[bot] avatar May 26 '25 09:05 vercel[bot]

"""

Walkthrough

本次更改在日期选择器相关组件中引入了 maxDate 属性，用于限制可选日期的上限。maxDate 通过 RangePicker 和 SinglePicker 组件传递至 Popup，再传至 PresetPanel，用于禁用超过最大日期的预设项，并在相关事件处理时加入判断，确保超出最大日期的预设不可交互。同时，新增了对应的测试用例验证禁用逻辑。

Changes

文件或路径 变更摘要
src/PickerInput/Popup/PresetPanel.tsx PresetPanelProps 新增 maxDate，渲染时禁用超过 maxDate 的预设项，相关事件处理增加判断
src/PickerInput/Popup/index.tsx PopupProps 新增 maxDate，并将其传递给 PresetPanel
src/PickerInput/RangePicker.tsx <Popup> 组件新增 maxDate 属性传递
src/PickerInput/SinglePicker.tsx <Popup> 组件新增 maxDate 属性传递
tests/picker.spec.tsx 新增测试，验证禁用预设项不会触发 hover 或 change 事件

Sequence Diagram(s)

sequenceDiagram
    participant RangePicker/SinglePicker
    participant Popup
    participant PresetPanel

    RangePicker/SinglePicker->>Popup: 传递 maxDate 属性
    Popup->>PresetPanel: 传递 maxDate 属性
    PresetPanel->>PresetPanel: 判断预设项是否超出 maxDate，超出则禁用
    User->>PresetPanel: 鼠标悬停或点击预设项
    PresetPanel-->>User: 若禁用则不响应事件

Suggested reviewers

  • zombieJ
  • afc163

Poem

🐰
兔儿跳跃在代码田，
日期上限定新篇。
预设禁用不再乱，
测试验证保安全。
maxDate 护航选日间，
选择安心乐无边！
🌸📅✨
"""

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/PickerInput/Popup/PresetPanel.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js Error: Cannot find module '@umijs/fabric/dist/eslint' Require stack:

  • /.eslintrc.js
  • /node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli-engine/cli-engine.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/index.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js
  • /node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js at Module._resolveFilename (node:internal/modules/cjs/loader:1405:15) at require.resolve (node:internal/modules/helpers:145:19) at Object. (/.eslintrc.js:2:21) at Module._compile (node:internal/modules/cjs/loader:1734:14) at Object..js (node:internal/modules/cjs/loader:1899:10) at Module.load (node:internal/modules/cjs/loader:1469:32) at Module._load (node:internal/modules/cjs/loader:1286:12) at TracingChannel.traceSync (node:diagnostics_channel:322:14) at wrapModuleLoad (node:internal/modules/cjs/loader:235:24) at Module.require (node:internal/modules/cjs/loader:1491:12)
📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a76aa66dbb6b569833100fa8a759caa62fc6be2 and 201eb0bc1ec6593ac14d340a212bacc8afcb421f.

📒 Files selected for processing (1)
  • src/PickerInput/Popup/PresetPanel.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/PickerInput/Popup/PresetPanel.tsx
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 26 '25 09:05 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.80%. Comparing base (0e289d5) to head (201eb0b).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          65       65           
  Lines        2669     2675    +6     
  Branches      737      742    +5     
=======================================
+ Hits         2637     2643    +6     
  Misses         29       29           
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 29 '25 08:05 codecov[bot]