picker icon indicating copy to clipboard operation
picker copied to clipboard

Update deprecated keyboard event props

Open chilled-capybara opened this issue 2 years ago • 3 comments

Fixes https://github.com/react-component/picker/issues/696.

Typescript doesn't contain the defintions for event.key so these have been done as strings. This could possibly be achieved by adding support in rc-util or using something like ts-key-enum.

I've updated the relevant commented-out code just to ensure the meaning isn't lost. Also, I've run prettier on the files I've worked on, the unrelated changes are in a dedicated commit.

chilled-capybara avatar Dec 12 '23 22:12 chilled-capybara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 10:41pm

vercel[bot] avatar Dec 12 '23 22:12 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09b3ab1) 98.94% compared to head (a2de18e) 98.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          56       56           
  Lines        2458     2458           
  Branches      747      740    -7     
=======================================
  Hits         2432     2432           
  Misses         24       24           
  Partials        2        2           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 13 '23 03:12 codecov[bot]

Conflicted

afc163 avatar Jan 30 '24 05:01 afc163