picker icon indicating copy to clipboard operation
picker copied to clipboard

fix: range-arrow fully supports the property dropdownAlign

Open linaaaqi opened this issue 3 years ago • 6 comments

fix: range-arrow fully supports the property dropdownAlign (ant-design/ant-design#34523)

linaaaqi avatar Mar 16 '22 09:03 linaaaqi

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/8wfWeZEB4pKxHAYC9RXEExBvNBs7
✅ Preview: https://picker-git-fork-losgif-master-react-component.vercel.app

vercel[bot] avatar Mar 16 '22 09:03 vercel[bot]

Codecov Report

Merging #364 (599ad38) into master (523ffd6) will decrease coverage by 0.40%. The diff coverage is 71.87%.

:exclamation: Current head 599ad38 differs from pull request most recent head dd6e09f. Consider uploading reports for the commit dd6e09f to get more accurate results

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   99.53%   99.12%   -0.41%     
==========================================
  Files          46       46              
  Lines        2148     2173      +25     
  Branches      633      647      +14     
==========================================
+ Hits         2138     2154      +16     
- Misses          8       17       +9     
  Partials        2        2              
Impacted Files Coverage Δ
src/RangePicker.tsx 97.96% <70.96%> (-2.04%) :arrow_down:
src/PickerTrigger.tsx 100.00% <100.00%> (ø)
src/PickerPanel.tsx 100.00% <0.00%> (ø)
src/generate/dayjs.ts 100.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Mar 16 '22 09:03 codecov[bot]

靠右对齐时的箭头位置计算目前是直接计算left定位,似乎计算right更简洁。
但是Trigger会有计算问题,导致左右选择器的切换会重新渲染,用户体感就是切换的时候闪一下。

linaaaqi avatar Mar 16 '22 09:03 linaaaqi

@zombieJ 给个建议?

靠右对齐时的箭头位置计算目前是直接计算left定位,似乎计算right更简洁。 但是Trigger会有计算问题,导致左右选择器的切换会重新渲染,用户体感就是切换的时候闪一下。

linaaaqi avatar Mar 31 '22 01:03 linaaaqi

@MadCcc 跟进一下

afc163 avatar Jul 22 '22 12:07 afc163

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
picker ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 1:52AM (UTC)

vercel[bot] avatar Jul 26 '22 01:07 vercel[bot]