picker
picker copied to clipboard
Format titleCell with locale
I encountered the same issue as https://github.com/ant-design/ant-design/issues/31339
Alternative solution to https://github.com/react-component/picker/pull/273
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/react-component/picker/DANeVMS6fUmJdFfUwGtQUK8tKtQN
✅ Preview: https://picker-git-fork-hensansi-format-titlecel-79de3d-react-component.vercel.app
Regarding the coverage, it is a breaking change due to the current locales, https://github.com/react-component/picker/blob/master/src/locale/en_US.ts#L19
I will look into why rc-picker-cell-end
disappears
Codecov Report
Merging #312 (a71f9f9) into master (13e10ec) will decrease coverage by
0.00%
. The diff coverage is100.00%
.
:exclamation: Current head a71f9f9 differs from pull request most recent head b7dc951. Consider uploading reports for the commit b7dc951 to get more accurate results
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 99.52% 99.52% -0.01%
==========================================
Files 45 45
Lines 2118 2117 -1
Branches 627 627
==========================================
- Hits 2108 2107 -1
Misses 8 8
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/panels/DatePanel/DateBody.tsx | 96.00% <100.00%> (ø) |
|
src/panels/PanelBody.tsx | 100.00% <100.00%> (ø) |
|
src/utils/timeUtil.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 13e10ec...b7dc951. Read the comment docs.
I just noticed that there are harcoded defaults in other places/not using the locale (enGB) e.g.
RangePicker https://github.com/react-component/picker/blob/8bc4cce34d2d53e8017e2d8b7a59c4f7db613d0c/src/utils/uiUtil.ts#L147
I can try to understand how we can use the locales for that too, I assumed that the code was using a default locale but that's not the case. Can you give me some hint on why it was structured this way/can I bring some suggestion to the table regarding this?