picker icon indicating copy to clipboard operation
picker copied to clipboard

Update to current hour, minute and second

Open gzqby opened this issue 4 years ago • 8 comments

解决bug:https://github.com/ant-design/ant-design/issues/25081 1.在DatetimePanel处理点选日期更新最新时分秒,在DatetimePanel只影响showtime的,是最小化修改。 2.在根源panelBody修改虽然能保证选择日期也能带出精确时分秒,但是showtime=false默认为time不敏感。 稳妥考虑选择1方案

gzqby avatar Jul 08 '20 04:07 gzqby

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/jtitv38n4 ✅ Preview: https://picker-git-fork-zgoby-hotfix-25081.react-component.vercel.app

vercel[bot] avatar Jul 08 '20 04:07 vercel[bot]

Codecov Report

Merging #101 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          43       43           
  Lines        1894     1896    +2     
  Branches      574      574           
=======================================
+ Hits         1886     1888    +2     
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
src/Picker.tsx 100.00% <ø> (ø)
src/PickerPanel.tsx 100.00% <ø> (ø)
src/RangePicker.tsx 100.00% <ø> (ø)
src/panels/DatetimePanel/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db04beb...c29a493. Read the comment docs.

codecov[bot] avatar Jul 08 '20 04:07 codecov[bot]

截屏2020-07-20 上午10 47 11

master 跑看是有覆盖到的,再确认一下?

zombieJ avatar Jul 20 '20 02:07 zombieJ

对对

gzqby avatar Jul 22 '20 01:07 gzqby

加一个测试用例哈~~thx

zombieJ avatar Jul 22 '20 07:07 zombieJ

@zgoby 可以merge 一下 master,不需要关了重开。我这边会 squash merge ~

zombieJ avatar Jul 27 '20 06:07 zombieJ

我是感觉交互逻辑还是有点问题,rangePicker保留第一个,第二个time就不变,还不如不改动或是最初版本的。你意思我是想把代码复原的.

gzqby avatar Jul 27 '20 06:07 gzqby

可以一个个来,先把单独的 DatePicker 搞定。这样已经解决了这个 issue。RangePicker 可以之后再拓展。

zombieJ avatar Jul 27 '20 08:07 zombieJ