notification icon indicating copy to clipboard operation
notification copied to clipboard

feat: Progress bar with customizable colors

Open yellowryan opened this issue 11 months ago • 3 comments

New feature for #52268

Summary by CodeRabbit

  • 新功能

    • 为通知组件添加了自定义进度条颜色的功能
    • 新增按钮触发具有自定义颜色的进度条通知
  • 测试

    • 新增测试用例验证自定义进度条颜色功能
  • 样式

    • 引入新的CSS变量 --progress-color 以控制进度条颜色
    • 提高样式的灵活性和可定制性

yellowryan avatar Jan 26 '25 23:01 yellowryan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2025 8:48am

vercel[bot] avatar Jan 26 '25 23:01 vercel[bot]

概述

演练

这个更改引入了通知组件进度条颜色的自定义功能。通过添加一个新的可选属性 progressBarColor,开发者现在可以为通知的进度条指定自定义颜色。这个特性涉及多个文件的修改,包括样式表、组件定义、接口和测试用例,以支持这一新的灵活性。

变更

文件 变更摘要
assets/index.less 引入 --progress-color CSS 变量,替换硬编码的进度条颜色
src/Notice.tsx 添加 progressBarColor 属性,支持进度条颜色自定义
src/hooks/useNotification.tsx NotificationConfig 接口中新增 progressBarColor 可选属性
src/interface.ts NoticeConfig 接口中新增 progressBarColor 可选属性
docs/examples/showProgress.tsx 添加演示自定义进度条颜色的按钮示例
tests/index.test.tsx 新增测试用例验证自定义进度条颜色功能

序列图

sequenceDiagram
    participant User
    participant Notification
    participant NoticeComponent
    participant StyleSystem

    User->>Notification: 调用通知并设置progressBarColor
    Notification->>NoticeComponent: 传递颜色参数
    NoticeComponent->>StyleSystem: 应用CSS变量
    StyleSystem-->>NoticeComponent: 渲染带有自定义颜色的进度条

诗歌

🐰 兔子的进度条魔法
颜色随心变,灵活如流光
红黄蓝绿舞,通知有乾坤
代码中的彩虹,闪耀不停歇!

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Notice.tsx

Oops! Something went wrong! :(

ESLint: 7.32.0

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@[email protected]/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6441e933e3d43e2c41ac623bbe56430205404aa and fd5064cfa981ee4c9d80667f01c08eea9388ead9.

📒 Files selected for processing (1)
  • src/Notice.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Notice.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jan 26 '25 23:01 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.74%. Comparing base (0a6f542) to head (fd5064c). Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   99.73%   99.74%           
=======================================
  Files           7        7           
  Lines         759      781   +22     
  Branches      123      126    +3     
=======================================
+ Hits          757      779   +22     
  Misses          2        2           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 27 '25 15:01 codecov[bot]