menu icon indicating copy to clipboard operation
menu copied to clipboard

fix(Menu): add setState condition in updateMiniStore method to avoid …

Open grantedFine opened this issue 6 years ago • 3 comments

add setState condition in updateMiniStore method to avoid infinite call in componentDidUpdate

grantedFine avatar Feb 13 '20 09:02 grantedFine

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/menu/fot5i48vk ✅ Preview: https://menu-git-fork-grantedfine-fix-updateministore.react-component.now.sh

vercel[bot] avatar Feb 13 '20 09:02 vercel[bot]

Codecov Report

Merging #309 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   95.49%   95.50%   +0.01%     
==========================================
  Files          11       11              
  Lines         888      890       +2     
  Branches      265      267       +2     
==========================================
+ Hits          848      850       +2     
  Misses         40       40              
Impacted Files Coverage Δ
src/Menu.tsx 98.14% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a5e6cb...08c1299. Read the comment docs.

codecov[bot] avatar Feb 13 '20 09:02 codecov[bot]

conflict

afc163 avatar Oct 28 '20 14:10 afc163