input-number icon indicating copy to clipboard operation
input-number copied to clipboard

fix: make sure that the onChange event is triggered after onKeyDown

Open GiveMeACoke opened this issue 2 years ago • 4 comments

⚠️ InputNumber完全受控在Safari浏览器中切换到中文输入法后输入数字时,onChange事件会先于onKeyDown事件触发,导致提前触发precision格式化

🤖 Safari版本:15.1 (17612.2.9.1.20)

复现地址(使用Safari浏览器打开,输入法切换到中文拼音模式): https://stackblitz.com/edit/react-ts-ca5gfn

GiveMeACoke avatar Mar 01 '22 04:03 GiveMeACoke

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/VQ4ztdrLA8BaHHPgB1s3NYqEEg6T
✅ Preview: https://input-number-git-fork-givemeacoke-master-react-component.vercel.app

vercel[bot] avatar Mar 01 '22 04:03 vercel[bot]

Is this pr can be merged?

ruoqianfengshao avatar Mar 31 '22 06:03 ruoqianfengshao

Codecov Report

Merging #399 (f7d3483) into master (d3de147) will decrease coverage by 1.24%. The diff coverage is 50.00%.

:exclamation: Current head f7d3483 differs from pull request most recent head 1cc328d. Consider uploading reports for the commit 1cc328d to get more accurate results

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   97.76%   96.52%   -1.25%     
==========================================
  Files           9        9              
  Lines         448      460      +12     
  Branches      116      118       +2     
==========================================
+ Hits          438      444       +6     
- Misses         10       16       +6     
Impacted Files Coverage Δ
src/InputNumber.tsx 95.50% <50.00%> (-2.91%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Mar 31 '22 06:03 codecov[bot]

@zombieJ Is there any block for code review? We will fix code if it has any un-standard code immediately. Thanks~

ruoqianfengshao avatar Apr 18 '22 03:04 ruoqianfengshao