dialog

dialog copied to clipboard

allow change close aria-label

4

Allow change close aria-label fixing accessibility issues for other language than englisch

DmitriBountsman

static aria-label, no possibility to change for other language

3

There is no possibility to change aria-label either via a locale file or component properties. That breaks disability tests for other languages (in my case German). https://github.com/react-component/dialog/blob/ecc8da988f03ef2d54e67f6e77a2f53483b812aa/src/Dialog/Content/Panel.tsx#L100

DmitriBountsman

chore: Bump @types/keyv from 3.1.4 to 4.2.0

2

Bumps [@types/keyv](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/keyv) from 3.1.4 to 4.2.0. Commits See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: #...

dependabot[bot]

chore: Bump react from 16.14.0 to 18.2.0

2

Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 16.14.0 to 18.2.0. Release notes Sourced from react's releases. 18.2.0 (June 14, 2022) React DOM Provide a component stack as a second argument to onRecoverableError. (@​gnoff in...

dependabot[bot]

fix: invalid autofocus

5

fix https://github.com/ant-design/ant-design/issues/41239 link #350 react中的`autoFocus`似乎是react模拟的，并非原生的autofocus。https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactDOMHostConfig.js#L522-L528 `rc-potral`默认的挂载点似乎不太稳定，有可能虚拟dom渲染的时候挂载点还没添加到页面，或者添加后又被移除（`visible`为false的情况），导致`autofocus`失效。

acyza

This line https://github.com/react-component/dialog/blob/4f70824474b6988e79b8461341b37dce23ea19ff/src/DialogWrap.tsx#L45 injects css from rc-portal https://github.com/react-component/portal/blob/37d489d896a82f5e25ffdac963ce77c863a9da17/src/useScrollLocker.tsx#L27-L30 and it's not possible to opt out of it. it would be great if it was possible

vxsx

add fullscreen button

1

possible fix https://github.com/ant-design/ant-design/issues/39498

long76

autoFocus input not working within dialog

1

When using `` within a modal the input will not be focused because the modal captures focus. See [library code examples](https://github.com/react-component/dialog/blob/cb6f8f0dbad9656b03d18c036ba4f7525b31d3d0/docs/examples/ant-design.tsx) or [live examples ](https://dialog-react-component.vercel.app/demo/ant-design) Appears to be due to...

SamKirkland

Add CodeQL workflow for GitHub code scanning

1

Hi `react-component/dialog`! This is a one-off automatically generated pull request from LGTM.com :robot:. You might have heard that we’ve integrated LGTM’s underlying CodeQL analysis engine natively into GitHub. The result...

lgtm-com[bot]

chore: Bump eslint from 7.32.0 to 9.6.0

1

Bumps [eslint](https://github.com/eslint/eslint) from 7.32.0 to 9.6.0. Release notes Sourced from eslint's releases. v9.6.0 Features e2b16e2 feat: Implement feature flags (#18516) (Nicholas C. Zakas) 8824aa1 feat: add ecmaVersion: 2025, parsing duplicate...

dependabot[bot]