Accessibility error fixed: ARIA hidden element must not contain focus…

[Ke1sy]

This fix is made to solve the reported issue "Accessibility error: ARIA hidden element must not contain focusable elements" https://github.com/react-component/dialog/issues/287

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
dialog	❌ Failed (Inspect)			Mar 30, 2023 at 10:42AM (UTC)

[codecov[bot]]

Codecov Report

Merging #288 (c6b4d1a) into master (646efc7) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head c6b4d1a differs from pull request most recent head fca6971. Consider uploading reports for the commit fca6971 to get more accurate results

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.02%     
==========================================
  Files           7        7              
  Lines         160      162       +2     
  Branches       50       52       +2     
==========================================
+ Hits          157      159       +2     
  Misses          2        2              
  Partials        1        1              

Impacted Files	Coverage Δ
src/Dialog/Content/Panel.tsx	100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[afc163]

Conflicting

[Ke1sy]

@afc163 @zombieJ

Conflicting

I resolved conflicts, could you please recheck it?

[zombieJ]

Hmm...since this dom is used for tab loop in the modal. So if it make to aria-hidden=false, it should use some aria-label or title to tell that what this work for.

[mellis481]

@zombieJ Are you asking @Ke1sy a question with regard to the changes in this PR?

[zombieJ]

I mean current update may not help on a11y since above.

Hmm...since this dom is used for tab loop in the modal. So if it make to aria-hidden=false, it should use some aria-label or title to tell that what this work for.

[Ke1sy]

@zombieJ I am closing this PR as it's not actual any more, Axe devTools a11y plugin doesn't show this error any more. CC: @mellis481