react-router-bootstrap icon indicating copy to clipboard operation
react-router-bootstrap copied to clipboard

`LinkContainer` turns all children's tags into `a`'s.

Open dennisoelkers opened this issue 4 years ago • 1 comments

We are currently upgrading from react-router v3 to v5, therefore also upgrading react-router-bootstrap from v0.23.3 to v0.25.0. We have noticed that LinkContainer (which is just wrapping Route) is turning all children into a-tags, even though e.g. a Button component is passed.

Is this on purpose? Is there any way around this?

Right now it is breaking our tests (we are assuming e.g. that a button component is used in some places).

dennisoelkers avatar Oct 15 '20 15:10 dennisoelkers

This is something that I expect, as it works well with react bootstrap Button component. The final element is an anchor a with the style of a button.

antoHuman avatar Oct 21 '22 14:10 antoHuman