react-overlays icon indicating copy to clipboard operation
react-overlays copied to clipboard

The `target` prop should be optional in the TypeScript type definition

Open coryhouse opened this issue 4 years ago • 0 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Per the docs, the target prop should be optional. But TypeScript is requiring it.

Here is the diff that solved my problem:

diff --git a/node_modules/react-overlays/esm/Overlay.d.ts b/node_modules/react-overlays/esm/Overlay.d.ts
index 2a06425..ee42e82 100644
--- a/node_modules/react-overlays/esm/Overlay.d.ts
+++ b/node_modules/react-overlays/esm/Overlay.d.ts
@@ -10,7 +10,7 @@ export interface OverlayProps extends TransitionCallbacks {
     containerPadding?: number;
     popperConfig?: Omit<UsePopperOptions, 'placement'>;
     container?: DOMContainer;
-    target: DOMContainer;
+    target?: DOMContainer;
     show?: boolean;
     transition?: React.ComponentType<{
         in?: boolean;

This issue body was partially generated by patch-package.

coryhouse avatar Aug 21 '21 20:08 coryhouse