dom-helpers icon indicating copy to clipboard operation
dom-helpers copied to clipboard
verified publisher icon react-bootstrap

getScrollAccessor on window seems wrong

Open satazor opened this issue 5 years ago • 1 comments

https://github.com/react-bootstrap/dom-helpers/blob/536ae60e6cb13df301575ffb497f9ba02bace32c/src/getScrollAccessor.ts#L19

When offset is pageYOffset, scrollTo will be invoked with scrollTo(currentPageYOffset, newPageYOffset). When offset is pageXOffset, scrollTo will be invoked with scrollTo(currentPageXOffset, newPageXOffset).

This doesn't seem to be right. What we want to do is to preserve the value of X when we are changing Y and vice-versa.

satazor avatar Aug 25 '20 03:08 satazor

ya seems like a bug!

jquense avatar Aug 25 '20 12:08 jquense