cleff icon indicating copy to clipboard operation
cleff copied to clipboard

GHC 9.4 compatibility

Open arybczak opened this issue 3 years ago • 6 comments

cleff just needs bumps of upper versions of base and template-haskell to build with 9.4.1.

Unfortunately the story for cleff-plugin seems to be more complicated due to removal of derived constraints.

arybczak avatar Aug 10 '22 11:08 arybczak

It wasn't too complicated, just a few shifts in the data constructors. https://github.com/re-xyr/cleff/pull/29

ErnestKz avatar Jun 13 '23 12:06 ErnestKz

Though I take it back, some extra work is needed to for the CPP pragmas.

ErnestKz avatar Jun 13 '23 12:06 ErnestKz

Any luck on the plugin?

goertzenator avatar Aug 17 '23 18:08 goertzenator

Hi. To let you know. I'm personally not aiming at fixing this issue at the moment.

Though an example of a fix can be seen here: https://github.com/polysemy-research/polysemy/commit/f9b19c022b0a5c18e473b0127172b6a3c4f94be2

ErnestKz avatar Aug 17 '23 22:08 ErnestKz

cleff seems to build fine on 9.4 and 9.6. Is this issue resolved?

(Relatedly, it requires --allow-newer for 9.8)

tomjaguarpaw avatar Apr 16 '24 09:04 tomjaguarpaw

Just a heads up that ghc-9.6 has problems with plugins in general. The link below is for polysemy, but I've had the same trouble in effectful. Surely cleff is affected too.

Ref https://github.com/commercialhaskell/stack/issues/6251

goertzenator avatar Apr 16 '24 18:04 goertzenator