DinkToPdf icon indicating copy to clipboard operation
DinkToPdf copied to clipboard

NuGet package does not link native libs

Open ajryan opened this issue 6 years ago • 7 comments

Rather than have to copy the libwk*.* native libs into the output folder, you can set up the NuGet package to include them automatically. They just need to be linked like so in the NuSpec:

<file src="..\..\v0.12.4\64 bit\libwkhtmltox.dll" target="runtimes\win7-x64\native" />
<file src="..\..\v0.12.4\64 bit\libwkhtmltox.so" target="runtimes\linux-x64\native" />
<file src="..\..\v0.12.4\64 bit\libwkhtmltox.dylib" target="runtimes\osx-x64\native" />

same goes for x86...

I'm happy to create a pull request if you'd like.

Thanks!

ajryan avatar Dec 20 '17 06:12 ajryan

Hi @ajryan ,

If you could make a pull request it would be great.

rdvojmoc avatar Dec 22 '17 07:12 rdvojmoc

Will do. Do you want it to stay in VS2015 / project.json format? Or is it OK to push up to VS2017 / new csproj as well?

ajryan avatar Dec 23 '17 03:12 ajryan

Please update it to VS2017. Thanks.

rdvojmoc avatar Dec 23 '17 06:12 rdvojmoc

PR #18 - thanks!

ajryan avatar Dec 28 '17 19:12 ajryan

@ajryan thanks for the PR, I will review it in next week.

rdvojmoc avatar Jan 05 '18 07:01 rdvojmoc

Hi @rdvojmoc

Do you have any update on this ?

Kind regards Rob

robvanpamel avatar Feb 26 '18 16:02 robvanpamel

@rdvojmoc If you need any assistance i'd love to help out with the pullrequest or anything else on dinktopdf

JimWolff avatar Mar 08 '19 20:03 JimWolff