RDMO 2.2.0

[jochenklar]

[coveralls]

coverage: 91.454% (-0.1%) from 91.591% when pulling a84da437121fbac353c1a0874f9f04dcb3e836af on dev-2.2.0 into 065d195043b7ac34a7b6b3180dac69829a3974bc on main.

[jochenklar]

Rebased to 2.1.1.

[MyPyDavid]

rebased to 2.1.2 at https://github.com/rdmorganiser/rdmo/pull/892/commits/2dbdb49004ba05e66ef7d935eef99b61b62dbb54

[MyPyDavid]

rebased to main at 14f94ed86f331241ae0e911c0104cd1dad871782 but a test ~is failing~ needed to re-run

test:

• https://github.com/rdmorganiser/rdmo/actions/runs/7552905417/job/20562691026?pr=878#step:8:634

FAILED rdmo/projects/tests/test_viewset_project_snapshot.py::test_delete[7-1-guest-guest] - assert False

• where False = <bound method Path.exists of PosixPath('/home/runner/work/rdmo/rdmo/testing/media_root/projects/1/values/238/rdmo-logo.svg')>() "config.settings">.MEDIA_ROOT

[MyPyDavid]

needed to rebase on main because of changes to rdmo/core/templates/core/home_text_en.html

[jochenklar]

Force-pushed to remove the double commits. I cherry picked everything from 1bf0d46. The last two merge commits are just cherry picked emtpy. I hope this does not cause trouble later.

[MyPyDavid]

thanks for the cherry pick 🙏, should we set this PR to "ready for review" so that potential conflicts to main already become visible?

[MyPyDavid]

screenshots after merge and tests of import feature look fine 👍

[MyPyDavid]

I get this warning message in the browser when I browse /projects/:

Warning: Modal uses the legacy childContextTypes API which is no longer supported and
will be removed in the next major release. 
Use React.createContext() instead

.Learn more about this warning here: https://reactjs.org/link/legacy-context
Modal@webpack://rdmo/./node_modules/react-bootstrap/es/Modal.js?:197:30
Modal@webpack://rdmo/./rdmo/core/assets/js/components/Modal.js?:15:16
div
Projects@webpack://rdmo/./rdmo/projects/assets/js/components/main/Projects.js?:25:16
Main@webpack://rdmo/./rdmo/projects/assets/js/containers/Main.js?:24:16
ConnectFunction@webpack://rdmo/./node_modules/react-redux/es/components/connect.js?:240:103
Provider@webpack://rdmo/./node_modules/react-redux/es/components/Provider.js?:15:18
DndProvider@webpack://rdmo/./node_modules/react-dnd/dist/core/DndProvider.js?:43:25 react-dom.development.js:86:30

Does anybody else also see this message or is it my local setup? Maybe @CalamityC could look at this? It has to do with the Modal.

[jochenklar]

This is probably because of react-bootstrap, which we will get rid of eventually. I think its fine. We just need to stick to this React version for now.

[MyPyDavid]

I found a minor issue with icon colors in the management. Are these colors because of my faulty css variables or because of some missing css classes in the react components? 🤔 The green is my link-color and the dark is the visited color, but I would expect that all the icons get the same color combination right? So that those blue icons would also be green.

[jochenklar]

I will check.

[MyPyDavid]

I could look at it tomorrow as well, the leftover PRs are ready for review https://github.com/rdmorganiser/rdmo/pulls?q=is%3Aopen+is%3Apr+milestone%3A%22RDMO+2.2.0%22

[jochenklar]

I fixed a tiny race condition in the configureStore for projects.