rdmo icon indicating copy to clipboard operation
rdmo copied to clipboard

Make rdmo's own plugins installable as optional dependencies

Open afuetterer opened this issue 1 year ago • 5 comments

Rationale / Begründung

Should rdmo's own plugins be installable as optional dependencies?

With the new pyproject.toml based setup, you can install extra dependencies with pip, e.g.

pip install rdmo[dev ] or pip install rdmo[postgres]

Should the same logic apply to its own plugins?

pip install rdmo[plugins] or pip install rdmo[re3data]

What do you think?

Affected

Admins

References / Verweise

  • https://github.com/rdmorganiser/rdmo-plugins
  • https://github.com/rdmorganiser/rdmo-re3data/
  • ...

afuetterer avatar Sep 15 '23 07:09 afuetterer

Lets keep that open for the future!

jochenklar avatar Dec 14 '23 09:12 jochenklar

Would this be desirable?

Is it useful to be able to install a plugin via pip install rdmo[re3data]? If yes, then I can just add this now. If no, I opt for closing this issue.

I am unsure if rdmo-plugins is a good name, because that repo has multiple plugins residing in it. But the other plugins like re3data etc. could be nice to install this way.

Should they be published via PyPI someday or is installing via GitHub the way to go?

afuetterer avatar Dec 14 '23 09:12 afuetterer

I think we can only add them if they are on PyPI and for this we first need to talk about who is maintaining this.

jochenklar avatar Dec 14 '23 09:12 jochenklar

I see, that makes sense.

afuetterer avatar Dec 14 '23 09:12 afuetterer

Maybe we can add trusted publishing to pypi from the plugins repositories?

It would need initial setup on the rdmo pypi plugins settings, once per project and adding a github actions workflow per repo.

The workflow could be triggered by a github release.

I think the maintenance burden should be minimal.

afuetterer avatar Jul 13 '24 09:07 afuetterer