Daniel Markstedt
Daniel Markstedt
Note that there's a new bug in the latest astyle which causes it to ignore the reference operator alignment in function arguments. It always center align the operator. Let's give...
This is neat. Let's give it a go. The commit hash is likely to change after a rebase merge, so it's something that we create after the fact I think.
abandoning this for now; astyle is not getting a bugfix anytime soon it seems, and when going back to an earlier version that didn't have this bug, there were other...
@nucleogenic good questions! I am still experimenting here, not all functionality replicated in meson yet. I also want to make sure that it's not slower or more unstable when building...
Right now I'm stuck at the unit tests. The suite crashes in `PiscsiExecutorTest.ProcessDeviceCmd` when built with meson.
Actually, I found out now there are more tests that are failing when you randomize the execution order. The gtest library has built-in functionality for randomization: f.e. `GTEST_SHUFFLE=1 ./build/cpp/piscsi_test` What...
Pushed a fix that does thorough cleanup between each StorageDeviceTest test. Now I don't get any more test failures when shuffling. Added the GTEST_SHUFFLE flag to the workflow now to...
Thanks for the review! For the record, I'm holding off on this to do more testing with actual SCSI hosts. I'm a little paranoid since I don't fully understand some...