auryn icon indicating copy to clipboard operation
auryn copied to clipboard

Upgrade phpunit, switch CI, PHP8 Fix

Open baohx2000 opened this issue 4 years ago • 6 comments

Upgraded phpunit, switch to github actions, fix for php 8. Take it or leave it.

I'll do another PR with just the php 8 fix.

baohx2000 avatar Dec 08 '20 19:12 baohx2000

I forgot this exists and did the changes manually. -.-

https://github.com/amphp/injector/commit/d657e9d7a017ea498817c13f4f5cd4853cc21dee

kelunik avatar Mar 04 '21 21:03 kelunik

I forgot this exists and did the changes manually. -.-

amphp/injector@d657e9d

Is it a fork of this repository ? If so, why doesn't github show it as a fork ?

Also, what about this repository. Is this now unmaintained ?

In that case it would be better to archive this repository and used the one in amphp

faizanakram99 avatar Aug 10 '21 15:08 faizanakram99

It is a fork, but removed linkage is probably mainly due to namespace changes and default PHP version requirements without having done a major version bump. Hopefully someone can get a note and link into the readme on this repo. IIRC, there is an issue or comment somewhere here about moving to amphp.

baohx2000 avatar Aug 10 '21 16:08 baohx2000

The API changed quite a lot, yeah, we'll add links once there's a new release.

kelunik avatar Aug 10 '21 16:08 kelunik

Ah ok, thanks

faizanakram99 avatar Aug 10 '21 17:08 faizanakram99

Feedback on the new API is highly appreciated!

kelunik avatar Aug 10 '21 18:08 kelunik

Thanks for the inspiration.....I eventually got around to upgrading things, but for reasons didn't accept the PR.

Probably going to be doing a 2.0 release 'soon'.

Danack avatar Apr 17 '23 13:04 Danack