openrave icon indicating copy to clipboard operation
openrave copied to clipboard

[quick] warning on empty geometry name

Open kanbouchou opened this issue 4 years ago • 4 comments

to make debugging easy.

kanbouchou avatar May 07 '21 08:05 kanbouchou

I think this change will produce too many warning messages. Empty geometry name is not entirely unexpected.

Puttichai avatar May 07 '21 08:05 Puttichai

@kanbouchou perhaps do this in KinBody::_ComputeInternalInformation instead..

rdiankov avatar May 27 '21 05:05 rdiankov

@kanbouchou perhaps do this in KinBody::_ComputeInternalInformation instead..

@rdiankov I have second thought. I want to assign a random (based on monotonically increasing counter or timestamp) name if name is empty, not just a warning. otherwise, it is hard to refer to geometries once added.

For example, currently we cannot remove geometry with empty name.

void KinBody::Link::RemoveGeometryByName(const std::string& geometryname, bool removeFromAllGroups)
{
    OPENRAVE_ASSERT_OP(geometryname.size(),>,0);

What do you think about assigning unique name automatically if geometry name is empty?

kanbouchou avatar Jun 16 '21 12:06 kanbouchou

@kanbouchou @Puttichai the new collision report structure sort of needs unique geometry names, otherwise it won't be able to display the right information. perhaps we should think about auto-assigning unique geometry names

rdiankov avatar Oct 11 '23 12:10 rdiankov