openrave icon indicating copy to clipboard operation
openrave copied to clipboard

Init variables, check for valid file pointers before using, provide valid return values

Open lazydroid opened this issue 1 year ago • 1 comments

This MR fixes minor issues in the using uninitialized variables, returning nollptr instead of std::string, using file pointers without checking them for validity and similar things. This is not a complete list of issues, but the most dangerously looking ones.

lazydroid avatar Sep 06 '24 10:09 lazydroid

Can you have Puttichai look at the changes related to planning? Thanks

rdiankov avatar Sep 06 '24 12:09 rdiankov

There's a conditional passing of NULL pointer with null pointer dereference, do you have any idea why do we need to convert vectors to raw pointers instead of just iterating over the vectors with the approximately same result?

image

lazydroid avatar Sep 10 '24 06:09 lazydroid

Looks good to me now.

Thank you!

lazydroid avatar Oct 25 '24 10:10 lazydroid

thanks~

rdiankov avatar Oct 26 '24 21:10 rdiankov