openrave
openrave copied to clipboard
WIP: Save json with uri hint
Summary
- Use uriHint by default.
Description
- Without uriHint,
referenceUriis contained into saved json file. - It seems the current
jsonwriter.cpponly contains all the resolved bodies into one file, soreferenceUriseems unnecessary. - In addition, if saved
referenceUriis unnecessarily contained in the file,- When we load it by
jsonreader.cpp, warning message is shown. - Other non-openrave model loader software cannot load it because referenced file does not exist.
- When we load it by
- I added
noUriHintoption just in case. It's unnecessary right now, but in future, once we support file saving preserving the reference files, it might be necessary.
Changing default option like this could affect a lot... we should have ziyan and yoshiki comment on this.
Changing default option like this could affect a lot... we should have ziyan and yoshiki comment on this.
thanks for your comment!
@yoshikikanemoto @ziyan
- I guess, the current
jsonwriter.cppdoes not requirereferenceUri. I'm not fully sure about the negative effect if we removereferenceUri. But, I'm not also sure there is positive effect if we havereferenceUri. - In my understanding,
referenceUriHintis something like comment, and no behavioral effect for the saved json file. Is this correct?
Thanks!
p.s. It looks some tests are failing and needs to investigate.