react-native-smooth-picker icon indicating copy to clipboard operation
react-native-smooth-picker copied to clipboard

Published 20 hours ago • verified publisher icon rdhox

Adds react-native-gesture-handler FlatList

Open jerearaujo03 opened this issue 3 years ago • 2 comments

Please check it, I'm newbie with TypeScript.

jerearaujo03 avatar Mar 17 '21 12:03 jerearaujo03

Issue #25

jerearaujo03 avatar Mar 17 '21 13:03 jerearaujo03

Thanks for your PR! I think it's not optimal to just add the library you need and to give the choice between the RN's Flatlist component and the gesture handler one. It add a dependence to the library that it doesn't need to function. I think you can just add an optional props where you can pass your wanted Flatlist componant to SmoothPicker. If the props is not undefined, the picker would use the props, and if it's undefined, it would use the RN's Flatlist.

What do you think?

rdhox avatar Apr 02 '21 08:04 rdhox