cortex icon indicating copy to clipboard operation
cortex copied to clipboard

Fix model_optimizer_options argument

Open dmitriy-serdyuk opened this issue 7 years ago • 4 comments

Either I do not understand how to use option model_optimizer_options or it will not work with current implementation.

This PR allows to write --o.model_optimizer_options "encoder={'lr': 0.01}".

dmitriy-serdyuk avatar Sep 24 '18 21:09 dmitriy-serdyuk

Actually, why do you need this argument? I can see now that that --o.optimizer_options supports passing a dictionary.

dmitriy-serdyuk avatar Sep 24 '18 21:09 dmitriy-serdyuk

@dmitriy-serdyuk Can you rebase this to dev? I think there might be some overlapping in the branches

rdevon avatar Oct 04 '18 15:10 rdevon

Done

dmitriy-serdyuk avatar Oct 04 '18 18:10 dmitriy-serdyuk

@dmitriy-serdyuk OK good. I'll fix the flake errors with dev and start merging.

rdevon avatar Oct 07 '18 02:10 rdevon