Robert Deutz comments

Results 92 comments of


                                            Robert Deutz

[5.3] Add CI Github workflow

Thanks!

[5.3] Deprecations: Changes we can make with 5.3 for the actionlog component (Backend)

@brianteeman using "Copyright" as word should also be ok, right? But I am looking what is the best way in terms of IDE configuration.

[5.3] Deprecations: Changes we can make with 5.3 for the actionlog component (Backend)

I did it again on another way, so anything should be fine now and the PR can be tested

[5.3] Deprecations: Changes we can make with 5.3 for the actionlog component (Backend)

I missed the whole file. About the code style for multiline chaining. Honestly I am not 100% sure what it better readable. The reformat applies when you have something like...

[5.2] Fix Postgres Problem in our testing

> From my point of view, it would be more beneficial to perform the cleanup in `beforeEach` rather than in `afterEach`. This prevents tests from failing after they are interrupted...

[6.0] RFC extend versioning, save releated information in history table and restore historical data

I now know why the tests are failing, when creating a banner over the api only the table class is used and not the model. So the problem is "only"...

[6.0] RFC extend versioning, save releated information in history table and restore historical data

Test and the compare view is fixed, so this here is ready to test again. @exlemor could you give some more information what you did. As you can see it...

[6.0] RFC extend versioning, save releated information in history table and restore historical data

Thanks for testing @brianteeman I think I have missed a case. I made a change and pushed it. I tried to check locally but -funny enough- the sampledata plugins are...

[6.0] RFC extend versioning, save releated information in history table and restore historical data

@brianteeman thanks I will try to get sampledata installed and try on my own. @LadySolveig The only thing you need to do, if you have used versioning in your component,...

[6.0] RFC extend versioning, save releated information in history table and restore historical data

At the moment it is more important to test if the functionallity works. So can you restore an older version of an article, banner etc. The problem with the compare/preview...