Sun-Valley-ttk-theme icon indicating copy to clipboard operation
Sun-Valley-ttk-theme copied to clipboard

Add hack

Open rdbende opened this issue 2 years ago • 3 comments

From Akuli/porcupine:

# TODO: the next 3 lines are a hack?
# If they are really needed, why it isn't in sv-ttk by default?
main_window.option_add("*Text.highlightThickness", "0")
main_window.option_add("*Text.borderWidth", "2")
main_window.option_add("*Text.relief", "solid")

rdbende avatar Jul 01 '23 08:07 rdbende

Add hack means add them to the sv_ttk as default?

littlewhitecloud avatar Oct 14 '23 11:10 littlewhitecloud

Yeah, though I'm not sure, if it makes sense to make them the default.

rdbende avatar Oct 14 '23 11:10 rdbende

Hightlightthickness is 0 means the Text widget will not show the highlight border and I agree this, because the border looks ugly. image And here is a screenshot that shows the difference between borderwidth=2 and the normal borderwidth, there are 1px black frame in the left and 2px grey frame in the bottom, so I disagree the second. image And the relief, here is the screenshot (test with borderwidth=2): image I think normal relief is better than the solid, so I think they can set the solid by themself.

So we just need set the highlightthickness=0 as default. (Of course this is just my option, maybe we can ask Akuli for options.)

littlewhitecloud avatar Oct 15 '23 05:10 littlewhitecloud