moor icon indicating copy to clipboard operation
moor copied to clipboard

we should have CRCs on disk-bound pages, and verify them on reads.

Open github-actions[bot] opened this issue 4 months ago • 0 comments

/ could live in the page header maybe

https://github.com/rdaum/moor/blob/47435a1442a1f5532c23944029e90982baa99bff/crates/db/src/rdb/paging/page_storage.rs#L71


/// Each page is a fixed size.
/// Uses io_uring to do the writes async. Reads are synchronous
///
/// TODO: deleted pages are not destroyed, they are just left on disk, which means if the same
///   page id is re-used, the old data could be read.
/// TODO: right now page storage is page-per-file which is maybe not the most efficient.
/// TODO: verify the fsync chained to writes via io_uring is actually working, and that
///   the durability guarantees are, at least approximately, correct.
/// TODO: we'll need reads once eviction/paging is implemented.
/// TODO: we should have CRCs on disk-bound pages, and verify them on reads.  
///   could live in the page header maybe

pub struct PageStore {

github-actions[bot] avatar Feb 10 '24 01:02 github-actions[bot]