rcsb
Make a new release
Please make a new release (1.0 from 2016 year is too old), with new version and new tarball.
@vitlav for what purpose is 1.0 too old? This repo holds a spec and some example files.
@vitlav for what purpose is 1.0 too old? This repo holds a spec and some example files. latest (1.0.0) mmtf-cpp library https://github.com/rcsb/mmtf-cpp does not pass tests with 1.0 specs.
@vitlav Could you elaborate on what tests exactly fail in mmtf-cpp v1.0.0 against 1.0 specs? I mean mmtf-cpp includes a checkout of mmtf as a submodule and is continuously tested against the data there so I am wondering what exactly you did and what errors you observed.
Following up on my own comment, I just tried to run the mmtf-cpp tests against the "v1.0" checkout of this mmtf repository. In mmtf-cpp, we include a specific checkout of this repository which (compared to v1.0) includes a few minor fixes in the specification and more importantly includes a few extra files in the test suite. Since (for simplicity) we hard-coded the paths to files we expect to find in test-suite/mmtf, those tests will fail. If I fix the paths manually, all tests pass (just proving that there is no incompatibility between mmtf-cpp v1.0.0 and v1.0 of the MMTF specs). As a side note also the master-branch of mmtf-cpp is perfectly compatible with the 1.0 specs.
Concluding: I actually agree with @vitlav that we should have a 1.1 release with the latest additions (e.g. extra fields and aromaticity which are already supported in the master branch of mmtf-cpp).
@vitlav Could you elaborate on what tests exactly fail in mmtf-cpp v1.0.0 against 1.0 specs? I mean mmtf-cpp includes a checkout of mmtf as a submodule and is continuously tested against the data there so I am wondering what exactly you did and what errors you observed. I built a rpm package with mmtf-cpp and standalone package with mmtf-spec needed in build time. Therefore I need reference to a version of release, not just submodule tag.
@vitlav I see. The installation of mmtf-cpp does not depend on this repository (matter of fact installing mmtf-cpp boils down to copying a couple of header-files), so you don't actually need it to build an mmtf-cpp package. The only dependency of mmtf-cpp is msgpack-c. The mmtf-cpp repo uses Catch2 and this repository purely for automated testing, but neither is needed to install/use mmtf-cpp.
So if you do not want to wait for a new mmtf-release, you could either just install mmtf-cpp without running the tests or rely on the mmtf-submodule to get the data needed to run the tests and delete it afterwards.