go-metrics icon indicating copy to clipboard operation
go-metrics copied to clipboard

NilTimer should execute function argument in Time

Open chewr opened this issue 6 years ago • 1 comments

The NilTimer implements the Timer's Time(func()) method but does so as a noop. In order to preserve behavior for callers which use this method and rely on the argument being executed, the NilTimer should execute the function that is passed to it.

https://github.com/rcrowley/go-metrics/blob/master/timer.go#L129

chewr avatar Mar 09 '18 19:03 chewr

this repository is dead ? or why the fix is still not on master ?

lexand avatar Mar 11 '20 13:03 lexand